fix(builtins): add d/w/y duration units to time.parse_duration_ns - #799
Open
Anand Krishnamoorthi (anakrish) wants to merge 3 commits into
Open
fix(builtins): add d/w/y duration units to time.parse_duration_ns#799Anand Krishnamoorthi (anakrish) wants to merge 3 commits into
Anand Krishnamoorthi (anakrish) wants to merge 3 commits into
Conversation
OPA supports 'd' (day), 'w' (week), and 'y' (365-day year) as duration unit suffixes; Regorus previously returned an error for those tokens. - Define DAY = 24 * HOUR, WEEK = 7 * DAY, YEAR = 365 * DAY constants - Add 'd', 'w', 'y' arms to the unit-matching arm of parse_duration() - Add YAML regression test covering individual units and a mixed '1d12h' compound duration Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPA supports
d(day),w(week), andy(365-day year) as duration unit suffixes; Regorus previously returned an UnknownUnit error for those tokens.Changes
DAY = 24 * HOUR,WEEK = 7 * DAY,YEAR = 365 * DAYinsrc/builtins/time/compat.rs"d","w","y"arms to the unit-matching block inparse_duration()Tests
New
tests/interpreter/cases/builtins/time/duration_units.yamlcovering:Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com