Add ErrorComposition class and integrate into estimation processes#3422
Open
msoeken wants to merge 1 commit into
Open
Add ErrorComposition class and integrate into estimation processes#3422msoeken wants to merge 1 commit into
msoeken wants to merge 1 commit into
Conversation
msoeken
commented
Jul 7, 2026
msoeken
commented
Member
- Introduced ErrorComposition to control error contribution methods (UnionBound and Product).
- Updated estimation functions to accept ErrorComposition as a parameter.
- Enhanced EstimationResult to manage error composition mode.
- Added tests to validate behavior of error composition modes.
- Introduced ErrorComposition to control error contribution methods (UnionBound and Product). - Updated estimation functions to accept ErrorComposition as a parameter. - Enhanced EstimationResult to manage error composition mode. - Added tests to validate behavior of error composition modes.
msoeken
requested review from
billti,
brad-lackey,
idavis and
minestarks
as code owners
brad-lackey
reviewed
Jul 7, 2026
| /// Advantages: always stays in ``[0, 1)``; it is tight (in fact exact) when | ||
| /// the errors are independent. | ||
| /// | ||
| /// Disadvantages: it relies on independence, so it can underestimate when |
Contributor
There was a problem hiding this comment.
This technique also suffers from finite precision issues when performing the computation on many small probabilities.
brad-lackey
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.