fix(evals): load UTF-8 BOM JSONL data#4188
Open
fengjikui wants to merge 1 commit into
Open
Conversation
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
github-actions
Bot
added
the
no-recent-activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8-sig"so files saved with a UTF-8 BOM are accepted._validate_and_load_datausing a UTF-8-SIG JSONL file.Root cause
pd.read_json(..., lines=True)treats the leading BOM as part of the first JSON token and raisesValueError: Expected object or valuefor UTF-8-SIG JSONL files.Fixes #3670
Validation
uv run --project src/promptflow-evals --with pandas python ...confirmedencoding="utf-8-sig"reads both UTF-8-SIG and normal UTF-8 JSONL.src/promptflow-evals/.venv/bin/python -m pytest src/promptflow-evals/tests/evals/unittests/test_evaluate.py -q(28 passed)