fix(azure): handle DatastoreType ImportError from azure-ai-ml>=1.33.0#4187
Open
Vitaliy-Pikalo wants to merge 2 commits into
Open
fix(azure): handle DatastoreType ImportError from azure-ai-ml>=1.33.0#4187Vitaliy-Pikalo wants to merge 2 commits into
Vitaliy-Pikalo wants to merge 2 commits into
Conversation
… (blob/client.py) Handle ImportError for DatastoreType and define constants locally.
… (_artifact_utilities.py) Handle ImportError for DatastoreType and define constants locally if the import fails.
Author
|
@microsoft-github-policy-service agree |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
azure-ai-ml1.33.0 removed the private moduleazure.ai.ml._restclient.v2022_10_01, causing aModuleNotFoundErrorwhen importingDatastoreTypein two files:promptflow/azure/_storage/blob/client.pypromptflow/azure/operations/_artifact_utilities.pyFix: wrap the import in a
try/except ImportErrorand fall back to a locally-definedDatastoreTypeclass. The string values are stable Azure REST API constants unchanged across versions.Fixes #4176.
All Promptflow Contribution checklist: