Close MCP stdio transport on stdin close#41656
Closed
liyanqing90 wants to merge 2 commits into
Closed
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
Please start with filing an issue |
Author
|
Filed issue as requested: #41664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endorcloseWhy
The stdio transport only mapped stdin
endtotransport.close(). Some client disconnect paths surface as stdinclose; in that case backend disposal could rely on the broader exit watchdog instead of the normal server close path. Closing the transport on both events lets the MCP server dispose its backend and close the launched browser promptly.Tests
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 npm cinpm run buildnpm run tscnpm run test-mcp -- launch.spec.ts --project=chrome