fix(webkit): do not lose in-memory cache storage records on navigation#41647
Closed
1chooo wants to merge 1 commit into
Closed
fix(webkit): do not lose in-memory cache storage records on navigation#416471chooo wants to merge 1 commit into
1chooo wants to merge 1 commit into
Conversation
CacheStorageManager closes caches that are no longer referenced by any web process connection, e.g. when the process is swapped on reload. CacheStorageCache::close() clears the records assuming they can be read back from disk, but ephemeral contexts use an in-memory store, so the records were silently lost while the cache name survived in the registry. Keep live in-memory caches open instead. Fixes: microsoft#41618
Member
|
The fix is changing core behavior which is not right, and it should be done in playwright-browser repo anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CacheStorageManagercloses caches once no web process references them (e.g. on the process swap during reload);close()clears the records assuming they can be re-read from disk. Ephemeral contexts use the in-memory store, so records were silently lost while the cache name survived.CacheStorageManager::removeUnusedCache().Fixes #41618