fix(dispatcher): lift progress controller creation before instrumentation#41643
Open
Skn0tt wants to merge 1 commit into
Open
fix(dispatcher): lift progress controller creation before instrumentation#41643Skn0tt wants to merge 1 commit into
Skn0tt wants to merge 1 commit into
Conversation
…tion ProgressController creation and registration now happens before the onBeforeCall instrumentation, so __abort__ messages can find the controller even when they arrive very early. ProgressController also stores an abort that arrives while it is still in the 'before' state and applies it once run() starts. This fixes the flaky "should throw an Error when aborted in-flight with a string reason" test on tracing bots, where the extra instrumentation overhead caused the abort message to arrive before the controller was registered.
Skn0tt
force-pushed
the
fix-abort-signal-race
branch
from
9f96567 to
0f6ac87
Compare
Skn0tt
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"7 flaky49491 passed, 1164 skipped Merge workflow run. |
Contributor
Test results for "MCP"4 failed 7639 passed, 1132 skipped Merge workflow run. |
yury-s
approved these changes
Jul 7, 2026
Contributor
Test results for "tests 2"4 fatal errors, not part of any test 41 flaky105898 passed, 4474 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lift
ProgressControllercreation and registration to happen beforeonBeforeCallinstrumentation, so that__abort__messages can find the controller even when they arrive very early.ProgressControllernow also stores an abort that arrives while it is still in the'before'state and applies it oncerun()starts.This fixes the flaky "should throw an Error when aborted in-flight with a string reason" test on tracing bots, where the extra instrumentation overhead caused the abort message to arrive before the controller was registered.