feat(test-runner): log aria snapshot failures during error context capture#41626
Open
pradapjackie wants to merge 1 commit into
Open
feat(test-runner): log aria snapshot failures during error context capture#41626pradapjackie wants to merge 1 commit into
pradapjackie wants to merge 1 commit into
Conversation
…pture Replace empty catch in _takePageSnapshot with debugLogger.log under pw:api so best-effort snapshot failures are observable when debugging. Fixes microsoft#41536.
pradapjackie
force-pushed
the
feat/aria-snapshot-debug-log
branch
from
76f1e0d to
18ccdc5
Compare
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41536.
Summary
catch {}inArtifactsRecorder._takePageSnapshotwithdebugLogger.log('api', ...)DEBUG=pw:apiMotivation
When a test fails, Playwright best-effort captures an AI aria snapshot for
error-context.md. If that capture fails (timeout, page closing, etc.), the failure was previously swallowed silently. WithDEBUG=pw:api, it is now observable.No change to user-facing behavior for normal runs.
Test plan
npm run eslint -- packages/playwright/src/index.ts tests/playwright-test/playwright.spec.tsnpm run ttest -- tests/playwright-test/playwright.spec.ts -g "should log aria snapshot failures"