Fix markdown highlighting of multi-line HTML tags#5422
Open
Gxrvish wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
An indented line inside an HTML block was matched by the indented code block rule, which consumed the whole line as a string token and thus never entered the tag state. Continuation lines of the same tag then fell back to plain text. Model CommonMark HTML blocks instead: a line that starts with at most 3 spaces of indent followed by an HTML tag enters a new htmlBlock state which lasts until the next blank line. Markdown block constructs, in particular indented code blocks, do not apply inside that state, so tags spanning multiple lines keep being tokenized as HTML.
Gxrvish
force-pushed
the
fix/markdown-multiline-html-tags
branch
from
July 25, 2026 07:16
a0c8807 to
156bf41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An indented line inside an HTML block was matched by the indented code block rule, which consumed the whole line as a string token and thus never entered the tag state. Continuation lines of the same tag then fell back to plain text.
Model CommonMark HTML blocks instead: a line that starts with at most 3 spaces of indent followed by an HTML tag enters a new htmlBlock state which lasts until the next blank line. Markdown block constructs, in particular indented code blocks, do not apply inside that state, so tags spanning multiple lines keep being tokenized as HTML.
Used Claude for help!! 🥂
Fixes: #5400