fix: escape square brackets in link text and image alt#1822
Open
Brumbelow wants to merge 1 commit into
Open
Conversation
Brumbelow
changed the title
Brumbelow
force-pushed
the
fix/link-text-bracket-escaping
branch
from
a63d2f1 to
3ae4b50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Link text and image alt containing
[/]were emitted unescaped inside[...](...)/, producing nested-bracket output that violates CommonMark.Problem
Repro on main:
Fix
_CustomMarkdownifyoverrides that build Markdown link syntax (convert_aandconvert_img). Keeping the escape local avoids flipping markdownify'sescape_misc=True, which would also touch ] \ & < ` [ > ~ = + | and affect other converters' output.Changes
packages/markitdown/src/markitdown/converters/_markdownify.py: escape brackets in link text (convert_a) and image alt (convert_img).packages/markitdown/tests/test_module_misc.py: new test_html_link_text_bracket_escaping covering both cases.Testing
Fixes #1302