Skip to content

Fix Claude plugin marketplace and agent discovery #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Brett Wilson (MSBrett) wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fix Claude plugin marketplace and agent discovery #2272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1cae969
fix: correct Claude plugin schema
MSBrett Aug 20, 2026
214dbcb
fix: load Claude plugin agents
MSBrett Aug 21, 2026
cfcbeab
test(agent-plugin): allow additional Claude component paths
MSBrett Aug 22, 2026
2a0755b
fix(agent-plugin): preserve cross-platform discovery
MSBrett Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .claude-plugin/marketplace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
{
"name": "microsoft-finops-toolkit",
"version": "15.0.0",
"source": "./plugins/microsoft-finops-toolkit",
"source": "./src/templates/agent-plugin",
Comment thread
MSBrett marked this conversation as resolved.

@RolandKrummenacher Roland Krummenacher (RolandKrummenacher) Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With both manifests now pointing here, the plugins/microsoft-finops-toolkit symlink has no remaining references anywhere on the branch — no grep hits — but is still committed. Worth removing it in this PR rather than leaving a dead pointer for the next reader to trip over.

Separately, strict: true on the next line is the documented default for marketplace plugin entries. Valid, but a no-op, and the new test now pins it. Fine to keep if it's deliberate belt-and-braces.

"strict": true,
"description": "Microsoft FinOps toolkit plugin for AI-powered cloud financial management.",
"category": "finops",
"homepage": "https://aka.ms/finops/toolkit"
Expand Down
26 changes: 21 additions & 5 deletions src/powershell/Tests/Unit/AgentPlugins.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ Describe 'Agent plugin manifest' {
$root.skills[0].TrimStart('./') | Should -Be $claude.skills[0].TrimStart('./')
$root.agents | Should -Be './agents/'
$root.mcpServers | Should -Be '.mcp.json'
$claude.agents | Should -BeNullOrEmpty
$claude.mcpServers | Should -BeNullOrEmpty
$claude.agents.Count | Should -Be 5
$claude.mcpServers | Should -Be './.mcp.json'
$claude.outputStyles | Should -Be './output-styles/'
}

Expand All @@ -48,11 +48,20 @@ Describe 'Agent plugin manifest' {
$claude = Get-Content (Join-Path $script:Plugin '.claude-plugin/plugin.json') -Raw | ConvertFrom-Json

$root.mcpServers | Should -Be '.mcp.json'
$claude.mcpServers | Should -BeNullOrEmpty
$claude.agents | Should -BeNullOrEmpty
$claude.mcpServers | Should -Be './.mcp.json'
Join-Path $script:Plugin '.mcp.json' | Should -Exist
}

It 'Declares resolvable paths for every Claude component' {
$claude = Get-Content (Join-Path $script:Plugin '.claude-plugin/plugin.json') -Raw | ConvertFrom-Json
$paths = @($claude.commands) + @($claude.agents) + @($claude.skills) + @($claude.mcpServers) + @($claude.outputStyles)

$paths.Count | Should -Be 9
$paths | ForEach-Object {
Join-Path $script:Plugin $_ | Should -Exist
}
}
Comment thread
MSBrett marked this conversation as resolved.

It 'Uses unpinned Azure MCP latest package in .mcp.json' {
$mcp = Get-Content (Join-Path $script:Plugin '.mcp.json') -Raw | ConvertFrom-Json
$args = $mcp.mcpServers.'azure-mcp-server'.args
Expand Down Expand Up @@ -167,7 +176,7 @@ Describe 'Plugin discovery and marketplaces' {
It 'Uses repository-root-relative marketplace sources' {
$marketplaces = @{
'.github/plugin/marketplace.json' = './plugins/microsoft-finops-toolkit'
'.claude-plugin/marketplace.json' = './plugins/microsoft-finops-toolkit'
'.claude-plugin/marketplace.json' = './src/templates/agent-plugin'
Comment thread
MSBrett marked this conversation as resolved.
Outdated
}

foreach ($marketplace in $marketplaces.Keys)
Expand All @@ -177,4 +186,11 @@ Describe 'Plugin discovery and marketplaces' {
$entry.source | Should -Be $marketplaces[$marketplace]
}
}

It 'Enables strict mode explicitly for the Claude plugin' {
$json = Get-Content (Join-Path $script:RepoRoot '.claude-plugin/marketplace.json') -Raw | ConvertFrom-Json
$entry = $json.plugins | Where-Object { $_.name -eq 'microsoft-finops-toolkit' }

$entry.strict | Should -BeTrue
}
}
8 changes: 8 additions & 0 deletions src/templates/agent-plugin/.claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,16 @@
"license": "MIT",
"keywords": ["finops", "cost-management", "reservations", "savings-plans", "cloud-optimization", "commitments", "credits", "macc"],
"commands": "./commands/",
"agents": [
"./agents/azure-capacity-manager.agent.md",
"./agents/chief-financial-officer.agent.md",
"./agents/finops-practitioner.agent.md",
"./agents/ftk-database-query.agent.md",
"./agents/ftk-hubs-agent.agent.md"
],
"skills": [
"./skills/"
],
"mcpServers": "./.mcp.json",
Comment thread
MSBrett marked this conversation as resolved.
Outdated
"outputStyles": "./output-styles/"
}
Loading