Skip to content

Fix integration tests breaking on SearchParameter duplicate-URL check on retry #5749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apurvabhaleMS wants to merge 34 commits into
base: main
Choose a base branch
from
+2 −1
Open

Fix integration tests breaking on SearchParameter duplicate-URL check on retry #5749

Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4e91054
Fix race condition in SetAndClearPendingSearchParameterStatus causing…
apurvabhaleMS Jul 31, 2026
c01d1ce
Revert projitems change — no file reference needed
apurvabhaleMS Jul 31, 2026
5581655
Fix review nit: remove DistinctBy mention from comments (lock-only fi…
apurvabhaleMS Jul 31, 2026
b9a5642
Address PR review comments from Copilot and CodeQL
apurvabhaleMS Aug 4, 2026
7f246f7
Address review findings: document single-slot limitation and batch-pa…
apurvabhaleMS Aug 4, 2026
8719eb3
Fix Bug 187119: reject PUT SearchParameter when URL already owned by …
apurvabhaleMS Aug 5, 2026
b9fb348
Refine Bug 187119 fix: allow PUT after hard-delete (PendingDelete/Pen…
apurvabhaleMS Aug 5, 2026
d318985
Extend Bug 187119 fix to POST (CreateResourceRequest) handler
apurvabhaleMS Aug 5, 2026
372b5cc
Revert lock in SetAndClearPendingSearchParameterStatus; remove associ…
apurvabhaleMS Aug 5, 2026
5052504
Fix test hygiene: delete SearchParameter created by WhenUpdatingWithU…
apurvabhaleMS Aug 5, 2026
d1660c2
Add E2E tests for Bug 187119: duplicate URL rejection on POST and PUT
apurvabhaleMS Aug 5, 2026
19237b6
Cleanup: remove irrelevant ReindexTests guard, simplify comments, ref…
apurvabhaleMS Aug 6, 2026
48485f7
Add URL duplicate check to update-URL path and add test for it
apurvabhaleMS Aug 6, 2026
a47cea8
Remove URL-change duplicate test; revert URL-too-long test to origina…
apurvabhaleMS Aug 6, 2026
c90c9b4
Simplify duplicate URL check: remove status conditions per Sergey's f…
apurvabhaleMS Aug 6, 2026
0829b86
Use GetSearchParametersByUrlsAsync for active-resource URL check; fix…
apurvabhaleMS Aug 6, 2026
5a3de06
Fix: also check duplicate URL when re-PUTting a soft-deleted SearchPa…
apurvabhaleMS Aug 6, 2026
894905d
Fix unit test failures: guard null URL, mock GetSearchParametersByUrl…
apurvabhaleMS Aug 6, 2026
1690372
Consolidate URL duplicate check; skip if same resource; remove redund…
apurvabhaleMS Aug 7, 2026
6e09903
Add unit tests: same-resource URL skip and different-resource URL rej…
apurvabhaleMS Aug 10, 2026
c995338
Merge remote-tracking branch 'origin/main' into personal/abhale/dupli…
apurvabhaleMS Aug 11, 2026
6030805
Merge remote-tracking branch 'origin/main' into personal/abhale/dupli…
apurvabhaleMS Aug 13, 2026
9554539
Merge remote-tracking branch 'origin/main' into personal/abhale/dupli…
apurvabhaleMS Aug 15, 2026
796e9ea
Add PendingDelete bypass + GUID URL per test run to prevent cross-run…
apurvabhaleMS Aug 15, 2026
3ac61e3
Use per-instance GUID prefix for SP test URLs; remove urlOverride; re…
apurvabhaleMS Aug 15, 2026
a06461d
Revert PendingDelete bypass; restore urlOverride with GUID-based shar…
apurvabhaleMS Aug 16, 2026
cb6b85f
Fix URL-too-long test: use GUID-based URL to prevent cross-run accumu…
apurvabhaleMS Aug 16, 2026
796034e
Fix sharedUrl length: use guidPrefix variable so URL is exactly 128 c…
apurvabhaleMS Aug 16, 2026
e2aaffd
Consolidate SP test URL building into CreateSearchParameterUrl helper…
apurvabhaleMS Aug 16, 2026
161be2e
Remove redundant null/whitespace URL guard in POST handler to match P…
apurvabhaleMS Aug 16, 2026
9b3e91a
Remove stale null-url comment in PUT handler
apurvabhaleMS Aug 16, 2026
593e162
Move null-url comment to PUT handler
apurvabhaleMS Aug 16, 2026
ef4ab17
Merge remote-tracking branch 'origin/main' into personal/abhale/dupli…
apurvabhaleMS Aug 21, 2026
59e6aa5
Make CreatePatientSearchParam URL unique to avoid duplicate-URL rejec…
apurvabhaleMS Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/FhirStorageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,8 @@ private async Task<SearchParameter> CreatePatientSearchParam(string searchParamN
{
var searchParam = new SearchParameter
{
Url = $"http://hl7.org/fhir/SearchParameter/Patient-{searchParamName}-Integration-FhirStorageTests",
// GUID suffix keeps the URL unique per call so leftover (lazy-deleted) resources from prior runs/tests don't trigger the duplicate-URL rejection.
Url = $"http://hl7.org/fhir/SearchParameter/Patient-{searchParamName}-Integration-FhirStorageTests-{Guid.NewGuid():N}",
Type = type,
#if Stu3 || R4 || R4B
Base = new List<ResourceType?>() { ResourceType.Patient },
Expand Down
Loading