Skip to content

fix: parse Accept header media type to allow parameters like charset=utf-8 #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MadhukarJukanti wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

fix: parse Accept header media type to allow parameters like charset=utf-8 #5740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.Health.Fhir.Api/Features/Filters/ValidateExportRequestFilterAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ public override void OnActionExecuting(ActionExecutingContext context)

if (!context.HttpContext.Request.Headers.TryGetValue(HeaderNames.Accept, out var acceptHeaderValue) ||
acceptHeaderValue.Count != 1 ||
!string.Equals(acceptHeaderValue[0], KnownContentTypes.JsonContentType, StringComparison.OrdinalIgnoreCase))
!MediaTypeHeaderValue.TryParse(acceptHeaderValue[0], out var parsedMediaType) ||
!string.Equals(parsedMediaType.MediaType.Value, KnownContentTypes.JsonContentType, StringComparison.OrdinalIgnoreCase))
{
throw new RequestNotValidException(string.Format(Api.Resources.UnsupportedHeaderValue, acceptHeaderValue.FirstOrDefault(), HeaderNames.Accept));
}
Expand Down
15 changes: 15 additions & 0 deletions ...h.Fhir.Shared.Api.UnitTests/Features/Filters/ValidateExportRequestFilterAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,21 @@ public void GivenARequestWithCorrectHeaderAndNoQueryParams_WhenGettingAnExportOp
_filter.OnActionExecuting(context);
}

[Theory]
[InlineData("application/fhir+json; charset=utf-8")]
[InlineData("application/fhir+json;charset=utf-8")]
[InlineData("application/fhir+json; charset=UTF-8")]
public void GivenARequestWithAcceptHeaderContainingMediaTypeParams_WhenGettingAnExportOperationRequest_ThenTheResultIsSuccessful(string acceptHeader)
{
// .NET HttpClient automatically appends "; charset=utf-8" to the Accept header.
// Validate that media type parameters do not cause the request to be rejected.
var context = CreateContext();
context.HttpContext.Request.Headers[HeaderNames.Accept] = acceptHeader;
context.HttpContext.Request.Headers[PreferHeaderName] = CorrectPreferHeaderValue;

_filter.OnActionExecuting(context);
}

[Theory]
[InlineData("respond-async", true)]
[InlineData("respond-async,handling=strict", true)]
Expand Down
Loading