Repository navigation
refactor: standardize error handling with sentinel errors - #119
Merged
Merged
Conversation
- Add ErrOperationAborted, ErrNilHistoryEvent, ErrNilEventTimestamp,
ErrNotExecutionStarted sentinel errors to backend package
- Replace bare errors.New() calls with sentinel errors in sqlite and
postgres backends for consistent error checking via errors.Is()
- Replace bare errors.New("unimplemented") in gRPC executor with
proper status.Error(codes.Unimplemented, ...) for gRPC compliance
- Fix typo: "multi-instance purge is not unimplemented" ->
"multi-instance purge is not yet implemented"
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kaibocai (kaibocai)
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"multi-instance purge is not yet implemented"