Skip to content

Deliver consistent spacing and safer browser Return behavior - #2119

Open
Brian Krabach (bkrabach) wants to merge 9 commits into
mainfrom
task/layout-delivery-dca3
Open

Brian Krabach (bkrabach) wants to merge 9 commits into
mainfrom
task/layout-delivery-dca3

Conversation

@bkrabach

Copy link
Copy Markdown
Collaborator

Change

Deliver the reviewed canonical spacing and safer Return changes from microsoft/amplifier-client-web#63 (merged as 616d5a1f2026f4f864bf185f8533433bcee47ec2, tree-identical to the selected reviewed ad9d5dfedddf12ea6e99910717280cc37a56da76). Whole 676-file snapshot, bytes/modes and source digest refreshed mechanically; no copied-source authoring. Source digest: 1c54edf8f8016ea7ba07d8f2bf90c1069ed07be5ef335fbf5dfbceaa3aa3b276.

  • Checkbox/search/select spacing, dense Settings and Work status/retry separation; error banner follows the chat/composer column.
  • Browser-local Return preference and capability default preserve IME, rich editing, explicit guarded Send and draft recovery. Visible effective guidance stays outside the compact writing border; 44px controls and the existing 72px compact ceiling remain.
  • Maintained outside-checkout installed journeys and synthetic fixture controls; strengthened measured geometry and storage acknowledgement oracles.
  • Add bounded external-static capture to the maintained frontend artifact helper. It verifies selected client, prepared source, shared inputs, paired-lock metadata and all generated bytes before/after capture; ordinary verify/apply remain unchanged. This does not grant build/release qualification.

Validation

One owned managed browser-test DTU only, matching prepared dependencies reused. Final actual tested host source 9398201912ee23be1857299e31397362f9b5daec (0.96.4 base); selected client ad9d5dfe, build 705284ec2b3ff778. Candidate wheel SHA-256 252a88c5d4fa12ee78ad8435ec9cab39a6527af8e44e3b46b8a71b117cedf99a; all 952 amplifier_web payload members verified after installation outside source/PYTHONPATH. Served app JS 38bd5508b47042912624cde094aa51bef6398b26fa17dd2f5fc12c4a404807a6, CSS 90bd6929302db8434ba2aaeab29cd433c96f82b93a932e7ab8696c805db4cc16.

PASS:

  • Canonical Return capability/event matrix, mounted failed-storage/disabled/readOnly and nine native/deferred rich-edit + undo/redo cases; shared controls accepted on unchanged production input.
  • Installed compact, Return and Markdown journeys. 24 compact detail/scheme/width cases at 900/520/390/320: field 56/60px, controls/editor 44px and centered; visible associated guidance outside border, no overflow. 160px negative control and two help-inside cause controls rejected.
  • Installed banner (1440/768/420/390), expanded Voice/Appearance/Routing/Testing/document-action scenes, and loading/error/retry geometry with real fixture host publication. Unchanged relevant CSS proof reused from exact earlier 8e4/2f97 builds, with full original wheel/served-byte joins and independent bounded screenshot review.
  • Frontend artifact helper: 53 passed in the same prepared DTU; full 316-file transferred static tree captured, verified, applied and web_client_build.py verify passed.

Retained finite raw results, hashes, screenshots, failed attempts and source snapshots: task d5715468 / working-files/layout-delivery/ and final delivery-final.json in the task-owned workspace output. Parent dca3 owns the independent source and pixel review receipts.

Current Main 89908c631 was merged without conflicts after the tested source. Its execution-preparation witness optimization, scheduling changes and accepted kernels delivery are preserved. UI/client/lock inputs are unchanged by that union; local final selected-client/static verification passed. The exact final union was not rebuilt or re-exercised in a new DTU, and the 939 wheel is not represented as that union. Artifact pairedServer remains the pinned shared-input identity 816c7a67…, not the actual 939 tested host.

Limits: synthetic host/runtime, no paid provider or copied user data/credentials. No physical mobile/native IME or actual 200% browser zoom acceptance (reflow viewport evidence is labelled). Earlier failures remain failures, not aggregate green. No release/version change, live adoption or Companion work.

Cleanup: sole DTU and owned image removed through managed receipts after finite evidence retention; inventory marked reaped. Original source and historical-contract archives retained. Independent absence observation is separate from our confirmed teardown.

@bkrabach

Copy link
Copy Markdown
Collaborator Author

Release coordination — RM owns the single next normal app cut for this layout handoff. Latest published app is v0.96.5; proposed patch is 0.96.6, with an explicit notice that Automatic Return inserts newlines on touch-capable browsers and explicit Send remains available. No build, tag, merge or publisher has been started for this cut. Required Fast/client-performance failures on f6c381 are being repaired by the existing layout owner; they will not be bypassed. Accepted rendered/package evidence is reused only at unchanged inputs. Remaining release preparation/output review and the one normal automatic publisher/official installed-package smoke stay in the RM lane. Context-limit incident recovery, its upstream approval question and Mac access are separate and are not claimed fixed by this UI change. No live adoption or repeat of 0.96.4/0.96.5 is commissioned. Any existing competing reservation must be reconciled before preparation, not raced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant