Skip to content

Close stale delivery warnings and remove redundant check writes - #2035

Merged
Brian Krabach (bkrabach) merged 8 commits into
mainfrom
fix/delivery-close-passive-checks
Nov 14, 2026
Merged

Brian Krabach (bkrabach) merged 8 commits into
mainfrom
fix/delivery-close-passive-checks

Conversation

@bkrabach

@bkrabach Brian Krabach (bkrabach) commented Nov 14, 2026 •

Copy link
Copy Markdown
Collaborator

User outcome

Close inactive failed/uncertain delivery warnings without resending, destroying original payloads, or claiming delivery. One closed flag in the existing tab-scoped outbox; inspect/reopen in Chat info or the pre-chat screen. Close need not wait for a passive check. Active sends, Stop, source boundaries, attachments and unknown truth are preserved. No controller, journal, timer, automatic retry or storage migration.

Accepted source and paired delivery

Canonical private client PR58 MERGED normally at cdc05979f0a2c572a7f2725d8a6b1f154ccaab72, preserving selected aa61d0c3b402e768d2db04482bec496465826350 ancestry and current shared-room source. Whole657 selected client files/modes verified; built assets acb32f11389fbc25 imported from exact source with all315 manifest hashes/316 files verified. Current0.91.0 main29e3 is preserved, not an older source rollback. Host early passive-check path removes redundant per-check command/save work and avoids copying unrelated execution, but retains dormant keyed admission and original positive receipt reconciliation.

Focused actual evidence

  • Current union148 Python delivery tests and87 client tests passed.
  • Outbox and new-chat browser journeys passed; exact old-shape unknown Close sends zero requests; reload/reconnect stays closed, inspect/reopen does not send, late accepted message renders once.
  • Added cold-positive dispatch test passed: second SQLite connection BEFOREshutdown reads accepted originalreceipt; no check-command row; subsequent restart with runtimeunknown retains acceptance/history.
  • Final pre-chat legacy Close/navigation/reload/reopen/explicitRetry case passed. Earlier overbroad shell.report and ambiguous Retry selector assertions were corrected only in tests; original failed receipts retained.
  • Final maintained build and offline source/artifact verify passed, archiveSHA c126a99d8818180db10b9816295b915c2e8c9a727b303001b029e1ac79b1b20b. Build runs before browser cache generation; no source-guard weakening.
  • Actual Astra gpt-6-astra/dd3e902c and Fable claude-fable-5-2/69e831de final same-brief reviews found no confirmed defect and closed earlier conditional evidence gaps. They inspected supplied excerpts/results only, not formal GitHub approvals.

Required current-head CI is running. Publication custody requested once through existing2034#6871179730; no version reserved or competing publisher. Actual two browser items remain unclosed pending delivered feature; no user resend or Arcade action. Source accepted, packaged candidate tested, published/adopted/livecleanup remain separate.

@bkrabach
Brian Krabach (bkrabach) marked this pull request as ready for review November 14, 2026 04:09
@bkrabach

Copy link
Copy Markdown
Collaborator Author

Exact-source acceptance: cd1d9ff, base29e3/0.91.0. Canonical client58 merged normally cdc05979 preserving selectedaa61 ancestry; whole657/source-build acb32f and316static/315manifest hashes verified. Actual independent Astra dd3e902c and Fable69e831de same-brief final reviews close earlier evidence conditions with no confirmed defect; not formal GitHub approval. Current Fast release checks43555244174 SUCCESS, clientperformance/native/browser/focused/platform/systemd executed checks SUCCESS; coordination contracts job43555244200 remains RUNNING and two declared skips remain skips. No failed current check observed. Required rules require Fast only; broad optional contracts are not added as a new feature/release gate, failures if any remain their own evidence. Standing Unified formal-review-only admin exception applies after technical acceptance and required checks; no protection change or failed-check bypass. Source merge has no version change and starts no publication. Single existing publication custody question2034#6871179730 remains pending; no transfer inferred. Actual browser cleanup remains pending feature release/adoption, no resend.

@bkrabach
Brian Krabach (bkrabach) merged commit 80730fe into main Nov 14, 2026
20 checks passed
@bkrabach

Copy link
Copy Markdown
Collaborator Author

VERIFIED DELIVERY CLOSEOUT (November 14): the already-published v0.94.1 tag resolves to1b09516bb31d84d57dfb70f0073490995d4f09ba and contains merged80730fe4c (26 commits ahead, zero behind). Actual publisher43619724873 SUCCESS; raw official43620153518/resolve132523810502 binds that source/version and installs the original published wheel with dependencies outside checkout, unsetPYTHONPATH/-I PROBE complete at9:16:26AM PST. Five broader jobs skipped, not passed. Independently downloaded originalwheel c38ac3fff9ab216e399f8c290cdb167dba38348fadd230bfa45590dc98841956 matches SHA256SUMS/API; release-source matches tag, selectedclientaa61/buildacb32f and all315 asset hashes verify; passive-check source repair present. No new build/test/release/adoption was run for this verification.

Actual original Mac tab now has BOTH original items already under Chat info > Closed delivery items, exact original text preserved and each marked Delivery unconfirmed / Closed by you. Closure predates this inspection; do not attribute it to an agent click today. Same-tab same-origin reload preserved both closed entries and recoverability; no resend, reopen, fake acceptance or bulk storage clear. Live host reports0.92.5 with this client, not a new0.94.1 live-adoption claim. Original uncertain delivery and unrelated UNKNOWN effects remain uncertain. User reiterated release followthrough as PRs merge; future owned merges must reach one coordinated publication plus official smoke, not stop at source acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants