Skip to content

.NET: Align WorkflowOutputEvent streaming deserialization with SourceId to ExecutorId rename #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyju wants to merge 6 commits into
base: main
Choose a base branch
from
+67 −2
Open

.NET: Align WorkflowOutputEvent streaming deserialization with SourceId to ExecutorId rename #6896

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4bdb107
Fix WorkflowOutputEvent streaming deserialization using renamed property
kshyju Jul 2, 2026
b22cb16
Add WorkflowOutputEvent streaming round-trip test
kshyju Jul 2, 2026
4111a97
Address PR review: TryGetProperty fallback and CHANGELOG entry
kshyju Jul 2, 2026
c07580e
Address PR review: add legacy sourceId test and CHANGELOG PR link
kshyju Jul 2, 2026
6db8858
Fix const naming to PascalCase for dotnet format
kshyju Jul 2, 2026
3d447af
Throw JsonException when neither executorId nor sourceId is present
kshyju Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dotnet/src/Microsoft.Agents.AI.DurableTask/Workflows/DurableStreamingWorkflowRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,9 +425,9 @@ private static bool TryParseWorkflowResult(string? serializedOutput, [NotNullWhe
}

// WorkflowOutputEvent
string sourceId = root.GetProperty("sourceId").GetString() ?? string.Empty;
string outputExecutorId = root.GetProperty("executorId").GetString() ?? string.Empty;
Comment thread
kshyju marked this conversation as resolved.
Outdated
object? outputData = GetDataProperty(root);
return new WorkflowOutputEvent(outputData!, sourceId);
return new WorkflowOutputEvent(outputData!, outputExecutorId);
Comment thread
kshyju marked this conversation as resolved.
}

return JsonSerializer.Deserialize(json, eventType, DurableSerialization.Options) as WorkflowEvent;
Expand Down
29 changes: 29 additions & 0 deletions ...s/Microsoft.Agents.AI.DurableTask.UnitTests/Workflows/DurableStreamingWorkflowRunTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,35 @@ public async Task WatchStreamAsync_CompletedWithEventsInOutput_YieldsEventsAndCo
Assert.Equal("result", completedResult.Result);
}

[Fact]
public async Task WatchStreamAsync_WorkflowOutputEvent_RoundTripsCorrectlyAsync()
{
// Arrange
WorkflowOutputEvent outputEvent = new("test-data", "executor-1");
string serializedEvent = SerializeEvent(outputEvent);
string serializedOutput = SerializeWorkflowResult("done", [serializedEvent]);

Mock<DurableTaskClient> mockClient = new("test");
mockClient.Setup(c => c.GetInstanceAsync(InstanceId, true, It.IsAny<CancellationToken>()))
.ReturnsAsync(CreateMetadata(OrchestrationRuntimeStatus.Completed, serializedOutput: serializedOutput));

DurableStreamingWorkflowRun run = new(mockClient.Object, InstanceId, CreateTestWorkflow());

// Act
List<WorkflowEvent> events = [];
await foreach (WorkflowEvent evt in run.WatchStreamAsync())
{
events.Add(evt);
}

// Assert
Assert.Equal(2, events.Count);
WorkflowOutputEvent result = Assert.IsType<WorkflowOutputEvent>(events[0]);
Assert.Equal("executor-1", result.ExecutorId);
Assert.Equal("test-data", result.Data?.ToString());
Assert.Empty(result.Tags);
}
Comment thread
kshyju marked this conversation as resolved.

[Fact]
public async Task WatchStreamAsync_CompletedWithoutWrapper_YieldsFailedEventAsync()
{
Expand Down
Loading