fix: Fix quiz locale matching for zh-CN#1843
Open
LHN012 wants to merge 1 commit into
Open
Conversation
|
@LHN012 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes Simplified Chinese quiz loading in the quiz app.
The app has a Simplified Chinese translation key named
zh_cn, but browsers usually report the locale aszh-CN. Because the app compared the raw locale withlocale.startsWith(key),zh-CNdid not matchzh_cn.This change normalizes locale values by lowercasing and replacing
-with_. It also lets thelocquery parameter choose the quiz translation before the quiz file is selected.Fixes no linked issue.
Type of change
Tested
npm run buildhttp://localhost:5173/?loc=zh_cnshows the Chinese quiz listhttp://localhost:5173/quiz/1?loc=zh_cnshows Lesson 1 pre-lecture quiz in Chinese