[FIX]: Evaluate probe verdicts over final traces - #149
Draft
Spencer Schoenberg (spencrr) wants to merge 3 commits into
Draft
[FIX]: Evaluate probe verdicts over final traces#149Spencer Schoenberg (spencrr) wants to merge 3 commits into
Spencer Schoenberg (spencrr) wants to merge 3 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 tasks
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-probe-cadence
branch
from
August 8, 2026 02:31
cb71f74 to
bc06529
Compare
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-probe-cadence
branch
2 times, most recently
from
August 27, 2026 17:30
2e9304b to
2cdbab0
Compare
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-probe-cadence
branch
from
September 8, 2026 20:41
2cdbab0 to
9f80bdf
Compare
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-probe-cadence
branch
from
September 8, 2026 22:46
9f80bdf to
a491cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes behavioral probes to evaluate the verdict once over the completed trace. Probes no longer stop on a detected verdict by default; callers can provide
stop_whenwhen an online condition should define an earlier terminal trace.This fixes sequence and prior-condition probes that cannot be resolved correctly from partial prefixes. Terminal verdict evidence is stored on
Result.terminal_evaluation, online stop evidence remains on turns withEvaluationPurpose.STOP_CHECK, and trace completion is recorded withTraceEndReason. Terminal evaluation stays inside the active session.This is the first layer that changes verdict cadence, so it bumps the private xdist envelope from v2 to v3. Controllers reject v2 envelopes rather than combining prefix-derived and terminal-trace statuses.
Depends on #148. Because the branches live on a fork, this PR temporarily includes lower-layer diffs and targets
main; those diffs disappear as dependencies merge.Breaking changes
Behavioral change:
Result.eval_resultsremains a turn-only compatibility view and is normally empty for probes withoutstop_when; useResult.terminal_evaluationfor terminal verdict evidence. Adaptive drivers without an online stop receive no evaluator feedback and may run tomax_turns.Checklist
pre-commit run --all-filespassesValidation after reslicing: the full suite passes with 1,178 tests and 5 skips; all pre-commit checks pass.