[FEAT]: Add durable terminal evaluation contract - #146
Open
Spencer Schoenberg (spencrr) wants to merge 1 commit into
Open
[FEAT]: Add durable terminal evaluation contract#146Spencer Schoenberg (spencrr) wants to merge 1 commit into
Spencer Schoenberg (spencrr) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-result-contract
branch
from
August 8, 2026 02:31
3cc7cc8 to
fb90c72
Compare
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-result-contract
branch
2 times, most recently
from
August 27, 2026 17:30
c3b5f80 to
9b7c6a6
Compare
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-result-contract
branch
from
September 8, 2026 20:41
9b7c6a6 to
ef98095
Compare
3 tasks
Copilot started reviewing on behalf of
Spencer Schoenberg (spencrr)
September 8, 2026 20:43
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A huge terminal confidence value can raise an uncaught overflow and abort controller-side xdist merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds durable terminal-evaluation and population provenance across core results, reporting, and xdist transport.
Changes:
- Adds terminal evaluation, trace-end reason, evaluation-purpose, and resolver APIs.
- Centralizes population validation.
- Extends persistence, truncation handling, tests, and documentation.
File summaries
| File | Description |
|---|---|
rampart/core/_population.py |
Adds shared population validation. |
rampart/core/types.py |
Adds provenance enums and turn purpose. |
rampart/core/result.py |
Extends results and verdict resolution. |
rampart/core/execution.py |
Validates trial parameters early. |
rampart/core/__init__.py |
Exports new core APIs. |
rampart/pytest_plugin/_xdist.py |
Transports and validates provenance. |
rampart/reporting/json_file.py |
Serializes terminal metadata. |
rampart/probes/_single_turn.py |
Clarifies turn-limit behavior. |
rampart/probes/_factory.py |
Updates probe API documentation. |
rampart/attacks/_xpia.py |
Clarifies XPIA turn limits. |
rampart/attacks/_factory.py |
Updates XPIA API documentation. |
tests/unit/core/test_types.py |
Tests enums and turn validation. |
tests/unit/core/test_result.py |
Tests result contracts and resolvers. |
tests/unit/core/test_execution.py |
Tests early trial validation. |
tests/unit/pytest_plugin/test_xdist.py |
Tests transport and truncation. |
tests/unit/pytest_plugin/test_xdist_aggregation.py |
Tests worker/controller persistence. |
tests/unit/reporting/test_json_file.py |
Tests JSON provenance output. |
docs/api/core-types.md |
Documents new core APIs. |
docs/usage/results-and-reporting.md |
Explains result provenance. |
docs/usage/xdist.md |
Documents envelope behavior. |
docs/probes/behavioral.md |
Updates probe turn-limit semantics. |
docs/attacks/xpia.md |
Updates XPIA turn-limit semantics. |
Review details
- Files reviewed: 22/22 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Spencer Schoenberg (spencrr)
force-pushed
the
dev/spencrr/trace-result-contract
branch
from
September 8, 2026 22:46
ef98095 to
acbf019
Compare
Spencer Schoenberg (spencrr)
marked this pull request as ready for review
September 8, 2026 23:16
Spencer Schoenberg (spencrr)
requested review from
a team
and
a balanced review from Copilot
September 8, 2026 23:16
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Spencer Schoenberg (spencrr)
September 8, 2026 23:16
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Extreme malformed integers can escape the xdist fail-closed error boundary.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
rampart/pytest_plugin/_xdist.py:998
- A sufficiently large integer overflows
float(), then its!rconversion can itself raiseValueErrorunder Python's integer-string digit limit. That exception escapes instead of becomingWorkerOutputError, so malformed worker data can abort the pytest hook rather than marking the run incomplete. Render the value through the existing safe string helper.
msg = f"Confidence could not be converted to float: {raw_confidence!r}."
- Files reviewed: 23/23 changed files
- Comments generated: 3
- Review effort level: Balanced
| try: | ||
| normalized_threshold = float(threshold) | ||
| except (OverflowError, ValueError) as exc: | ||
| msg = f"Expected finite number for population threshold, got {threshold!r}." |
|
|
||
| Raises: | ||
| TypeError: If ``value`` is not a string. | ||
| ValueError: If ``value`` is empty or exceeds the transport bound. |
| assert t.eval_result is er | ||
| assert t.eval_result is not None and t.eval_result.detected is True | ||
|
|
||
| def test_eval_purpose_round_trips(self): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the per-execution provenance needed before final-trace verdict cadence changes.
Result.terminal_evaluationstores the evaluator output for the terminal trace,Result.trace_end_reasonrecords why trace production ended, andTurn.eval_purposeidentifies online stop checks.Result.turn_evaluationsmakes the online evidence boundary explicit whileeval_resultsremains a compatibility view.The direct attack and probe resolvers require one evaluation and reject unknown runtime outcomes instead of falling through. Population provenance now shares validation across
PopulationRef,PopulationResult, andexecute_trials_async, with invalid thresholds rejected before an execution factory runs.This PR also includes the persistence work previously split into #147 so the contract cannot land without transport support. The current xdist v2 envelope and JSON report carry terminal evaluation, trace-end reason, turn purpose, and population provenance together. Malformed worker data fails closed, including overflowing confidence values, and oversized results produce bounded incomplete markers while retaining population provenance when it fits.
Breaking changes
None for valid callers. Invalid population provenance and malformed evaluator outcomes now fail early instead of being accepted or falling through.
Checklist
pre-commit run --all-filespassesValidation: 1,122 unit tests pass. Strict documentation build and all pre-commit checks pass.