Skip to content

Fix interactive Canary startup logs - #257

Merged
Yuqing (mydmdm) merged 1 commit into
alphafrom
hotfix/canary-interactive-logs
Sep 30, 2026
Merged

Yuqing (mydmdm) merged 1 commit into
alphafrom
hotfix/canary-interactive-logs

Conversation

@mydmdm

Copy link
Copy Markdown
Contributor

Summary

  • restore immediate log streaming for interactive scripts/start-huabu.sh alpha runs
  • keep readiness polling exclusive to UI-triggered --non-interactive redeployments
  • increase the non-interactive default readiness timeout from 120 to 300 seconds and make it configurable with HUABU_CANARY_READINESS_TIMEOUT_SECONDS

Validation

  • bash -n scripts/start-huabu.sh
  • invalid timeout configuration exits with status 2 and a clear error
  • pnpm exec prettier --check docs/architecture/canary-deployment.md
  • git diff --check

Cause

The initial implementation entered tail -f only after readiness succeeded. Interactive runs therefore showed no startup output and never reached log streaming when the 120-second readiness window expired, even though the tmux-hosted app continued starting successfully.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mydmdm
Yuqing (mydmdm) merged commit 5db0c64 into alpha Sep 30, 2026
2 checks passed
@mydmdm Yuqing (mydmdm) mentioned this pull request Sep 30, 2026
1 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant