Skip to content

revert "Usage error for transaction edits within event callback"#27581

Open
daesunp wants to merge 1 commit into
microsoft:mainfrom
daesunp:revert-edit-lock
Open

revert "Usage error for transaction edits within event callback"#27581
daesunp wants to merge 1 commit into
microsoft:mainfrom
daesunp:revert-edit-lock

Conversation

@daesunp

@daesunp daesunp commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Reverts PR#27571.

Copilot AI review requested due to automatic review settings June 22, 2026 21:54
@daesunp daesunp requested review from a team as code owners June 22, 2026 21:54
@daesunp daesunp changed the title revert b42d07fc3a revert "Usage error for transaction edits within event callback" Jun 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (46 lines, 3 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@daesunp daesunp enabled auto-merge (squash) June 22, 2026 21:59
@daesunp daesunp disabled auto-merge June 22, 2026 22:02
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size comparison

Base commit: f97f0829f077815acd790ed4c1445d091fdba823
Head commit: 103e9f45286c1640e2dee7927378dc4165172eec

Notable changes

No bundles changed by ≥ 500 bytes parsed.

Per-bundle deltas

@fluid-example/bundle-size-tests

  • azureClient.js: parsed 618933 → 618989 (+56), gzip 164786 → 164832 (+46)
  • odspClient.js: parsed 591767 → 591823 (+56), gzip 158878 → 158919 (+41)
  • aqueduct.js: parsed 525463 → 525498 (+35), gzip 140683 → 140713 (+30)
  • fluidFramework.js: parsed 392202 → 392170 (-32), gzip 111147 → 111148 (+1)
  • sharedTree.js: parsed 381589 → 381550 (-39), gzip 108542 → 108536 (-6)
  • containerRuntime.js: parsed 303813 → 303827 (+14), gzip 83188 → 83195 (+7)
  • sharedString.js: parsed 175984 → 175991 (+7), gzip 49445 → 49452 (+7)
  • experimentalSharedTree.js: parsed 160798 → 160798 (0), gzip 45804 → 45804 (0)
  • matrix.js: parsed 159845 → 159852 (+7), gzip 45411 → 45418 (+7)
  • loader.js: parsed 145221 → 145235 (+14), gzip 39052 → 39066 (+14)
  • odspDriver.js: parsed 104431 → 104452 (+21), gzip 32647 → 32657 (+10)
  • directory.js: parsed 66616 → 66623 (+7), gzip 18532 → 18540 (+8)
  • 748.js: parsed 58793 → 58793 (0), gzip 17826 → 17826 (0)
  • map.js: parsed 46709 → 46716 (+7), gzip 14310 → 14317 (+7)
  • odspPrefetchSnapshot.js: parsed 45650 → 45664 (+14), gzip 15276 → 15284 (+8)
  • 594.js: parsed 44493 → 44493 (0), gzip 13744 → 13744 (0)
  • summarizerDelayLoadedModule.js: parsed 30753 → 30753 (0), gzip 7767 → 7767 (0)
  • socketModule.js: parsed 26486 → 26493 (+7), gzip 7883 → 7891 (+8)
  • createNewModule.js: parsed 12480 → 12480 (0), gzip 4786 → 4786 (0)
  • summaryModule.js: parsed 3797 → 3797 (0), gzip 1860 → 1860 (0)
  • connectionState.js: parsed 724 → 724 (0), gzip 429 → 429 (0)
  • sharedTreeAttributes.js: parsed 666 → 673 (+7), gzip 431 → 441 (+10)
  • debugAssert.js: parsed 429 → 429 (0), gzip 299 → 299 (0)
  • FluidFramework-HashFallback.js: parsed 422 → 422 (0), gzip 316 → 316 (0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants