test: sandbox PR to exercise Copilot review - #1
Closed
mfide wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new examples/ console program intended as a sandbox to exercise Copilot review against the TLibEv codebase.
Changes:
- Added a new example program
ReviewSandbox.dprthat creates the default loop and prints the process id on Linux. - Introduced a Linux-only
getpidcall via a directexternalbinding.
| {$IFDEF FPC}SysUtils{$ELSE}System.SysUtils{$ENDIF}, | ||
| LibEv in '..\src\LibEv.pas'; | ||
|
|
||
| { Bu demo yalnizca Copilot review testi icindir - silinecek. } |
Comment on lines
+4
to
+13
| uses | ||
| {$IFDEF FPC}SysUtils{$ELSE}System.SysUtils{$ENDIF}, | ||
| LibEv in '..\src\LibEv.pas'; | ||
|
|
||
| { Bu demo yalnizca Copilot review testi icindir - silinecek. } | ||
|
|
||
| {$IFDEF LINUX} | ||
| { hand-rolled external even though the RTL already provides fpGetPID } | ||
| function c_getpid: Integer; cdecl; external 'c' name 'getpid'; | ||
| {$ENDIF} |
Comment on lines
+15
to
+23
| var | ||
| Loop: TEvLoop; | ||
| begin | ||
| Loop := TEvLoop.Default; | ||
| {$IFDEF LINUX} | ||
| Writeln('pid=', c_getpid); | ||
| {$ENDIF} | ||
| Loop.Free; | ||
| end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
{$MODE DELPHI}){ ev.c:NNNN name }reference to the libev sourceexternalbindingsdocs/MANUAL.md/README.mdupdated if the public API changedexamples/demo still passes, or a new self-testing demo was added