Skip to content

[perf] Optimize m.instrument/clj-collect! #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexander-yakushev wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −1
Open

[perf] Optimize m.instrument/clj-collect! #1295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b044f7
[perf] Optimize m.instrument/clj-collect!
alexander-yakushev Jun 28, 2026
e6687bd
Apply suggestion from @frenchy64
alexander-yakushev Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/malli/instrument.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,18 @@
(defn clj-collect!
([] (clj-collect! {:ns *ns*}))
([{:keys [ns]}]
(not-empty (reduce (fn [acc v] (let [v (-collect! v)] (cond-> acc v (conj v)))) #{} (vals (mapcat ns-publics (-sequential ns)))))))
(not-empty
(reduce (fn [acc nspace] ns-publics
Comment thread
alexander-yakushev marked this conversation as resolved.
Outdated
(let [nspace (the-ns nspace)]
(reduce-kv (fn [acc _ ^clojure.lang.Var v]
(if-let [v (and (instance? clojure.lang.Var v)
(= nspace (.ns v))
(not (:private (meta v)))
(-collect! v))]
(conj acc v)
acc))
acc (ns-map nspace))))
#{} (-sequential ns)))))

;;
;; CLJS macro for collecting function schemas
Expand Down