[Quaden2307]

Summary

--report-glean would not properly name a method on a Literal or LiteralString receiver. For example, "hello".title() would emit title rather than the expected str.title. This is because the closure that finds a method's defining class only handled class types, so a Literal fell through without a class name. The fix was at the start of defining_type closure, a Type::Literal is converted to its class with general_class_type, and a Type::LiteralString to str. The existing ClassType arm after that handles the naming.

Fixes #5250

• I am a human, and I fully understand the code I am submitting.

Test Plan

Added a string_literal case to the glean snapshot_test, with the five receivers from the issue. The snapshot was regenerated and all five methods now show as str.title/str.join. cargo test snapshot_test passes, and none of the other snapshots changed. test.py lint also passes.

[github-actions]

✅ This PR meets all requirements from our pull request checklist.

Optional recommendations:

• This PR is very large, which makes it slow and difficult to review. We strongly recommend splitting it into smaller PRs that can be merged independently. If that isn't possible, please structure it as a series of small commits. If you've already split it as far as is practical, no action is needed.

Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour.

[meta-codesync]

This pull request has been imported. If you are a Meta employee, you can view this in D131090557. (Because this pull request was imported automatically, there will not be any future comments.)

[rchen152]

Thanks for the PR! I left one readability suggestion. Once that's addressed, this should be good to merge.

[rchen152]

nit: Splitting the logic between two matchs makes it sort of hard to read. I'd recommend something like:

let cls = match &ty {
    ...  // extract the `ClassType`
    _ => return ty,
};
// get the class member, falling back to `Type::ClassType(cls.clone())`

[Quaden2307]

Done, thanks for the feedback!

[github-actions]

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

[rchen152]

Review automatically exported from Phabricator review in Meta.

[rchen152]

Thanks again, @Quaden2307!

[meta-codesync]

This pull request has been merged in 5619b5e.