Repository navigation
Show reveal_type output under the basic preset' - #5573
Closed
MarcoGorelli wants to merge 1 commit into
Closed
MarcoGorelli wants to merge 1 commit into
MarcoGorelli wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D130433047. (Because this pull request was imported automatically, there will not be any future comments.) |
MarcoGorelli
marked this pull request as ready for review
November 7, 2026 15:58
|
✅ This PR meets all requirements from our pull request checklist. Note: this comment updates automatically after changes to the PR. Updates may take up to half an hour. |
github-actions
Bot
added
waiting-for-author
waiting-for-reviewer
and removed
waiting-for-author
labels
stroxler
approved these changes
Nov 7, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 128c072. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5571. The issue's not been discussed, but this was very simple, and sometimes just submitting a PR is the fastest way to drive a discussion forwards
Test Plan