Skip to content

impl pgo #349 - #4731

Closed
asukaminato0721 wants to merge 1 commit into
meta:mainfrom
asukaminato0721:349
Closed

asukaminato0721 wants to merge 1 commit into
meta:mainfrom
asukaminato0721:349

Conversation

@asukaminato0721

Copy link
Copy Markdown
Collaborator

Summary

Fixes #349

on my computer

Training corpus: 0.1899s -> 0.1749s, 8.6% faster.

Held-out scripts corpus: 0.1181s -> 0.1127s, 4.8% faster.

Test Plan

@meta-codesync

meta-codesync Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D118027983. (Because this pull request was imported automatically, there will not be any future comments.)

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity for more than 2 weeks.

If you are still working on this this pull request, please add a comment or push new commits to keep it active. Otherwise, please unassign yourself and allow someone else to take over.

Thank you for your contributions!

@rchen152

rchen152 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@samwgoldman Looks like one for you, since it looks like you were looking into this from the issue history

@rchen152 rchen152 assigned samwgoldman and unassigned maggiemoss Nov 2, 2026
@rchen152
rchen152 requested review from samwgoldman and removed request for maggiemoss November 2, 2026 05:26
@samwgoldman

Copy link
Copy Markdown
Member

Thank you! I ended up implementing this separately in c7a8e3a. (On the validation set I see ~20% speed up, maybe you can try to reproduce?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate using Profile-Guided Optimization (PGO) and Post-Link Optimization (PLO)

4 participants