Repository navigation
impl pgo #349 - #4731
impl pgo #349#4731asukaminato0721 wants to merge 1 commit into
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D118027983. (Because this pull request was imported automatically, there will not be any future comments.) |
|
This pull request has been automatically marked as stale because it has not had recent activity for more than 2 weeks. If you are still working on this this pull request, please add a comment or push new commits to keep it active. Otherwise, please unassign yourself and allow someone else to take over. Thank you for your contributions! |
|
@samwgoldman Looks like one for you, since it looks like you were looking into this from the issue history |
|
Thank you! I ended up implementing this separately in c7a8e3a. (On the validation set I see ~20% speed up, maybe you can try to reproduce?) |
Summary
Fixes #349
on my computer
Training corpus: 0.1899s -> 0.1749s, 8.6% faster.
Held-out scripts corpus: 0.1181s -> 0.1127s, 4.8% faster.
Test Plan