Repository navigation
mypy_primer comments should hide the previous comment #5527
Description
see the comments in #2294 (comment), this PR is quite hard to follow because they are so massive. it's easy to miss comments in between them
Activity
DetachHead commentedon Nov 4, 2026
rchen152 commentedon Nov 5, 2026
This one is probably my fault; I switched the action we were using to hide mypy primer comments earlier this week.
rchen152 commentedon Nov 6, 2026
Ok, turns out this was because of a bug in the old comment hiding action we were using. It fetched comments without paging, so it didn't hide anything once a PR has enough comments. I've gone and manually minimized the old mypy primer comments.
There is another issue from the transition to the new action, which is that the last mypy primer comment from before the transition isn't minimized, but that should lead to only one extra visible mypy primer comment, which I think is okay.