Fix strict null typing issues in symbol extractor script#15983
Open
dcbaker wants to merge 2 commits into
Open
Conversation
dcbaker
force-pushed
the
submit/symbol-extractor-strict-null
branch
from
fcf3b78 to
f4122d1
Compare
There's some weird combination of "use argparse" and "don't use argparse" going on here. Plus some cases where a Protocol and help with typing.
There are a fair number of cases here where we return None and claim that we don't. This leads to cases where we will do the wrong thing when we get a None. Fix the annotations, fix the usages, tell mypy to enforce this.
dcbaker
force-pushed
the
submit/symbol-extractor-strict-null
branch
from
f4122d1 to
2661c59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reviewing #15975, I noticed that there are several more cases of this. Since I've been working on fixing strict null issues anyway, this seemed like a good place for mypy to help us out.