Allow buildtargets in generator's process function#15916
Draft
bonzini wants to merge 4 commits into
Draft
Conversation
bonzini
force-pushed
the
allow-targets-in-generator
branch
3 times, most recently
from
5ff4efd to
efbe039
Compare
bonzini
force-pushed
the
allow-targets-in-generator
branch
4 times, most recently
from
4bb6300 to
a3ac089
Compare
Contributor
Author
|
ebc9a67, the first patch in this tree, somehow makes the VS backend very flaky. But this makes no sense. :( |
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
The only effect of generate_genlist_for_target on non-GeneratedLists is to add elements to the parameters, but those are ignored in this specific recursive call. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
generate_genlist_for_target works on all generated sources, and has a silly do-nothing recursion for custom targets when operating on genlist.depends. Clarify that the genlist.depends recursion only needs to do something if it finds another generator. The old code would need changes if BuildTargets were added to genlist.depends; the new one does not. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Co-authored-by: Jens Wolvers <13272708+JWolvers@users.noreply.github.com>
bonzini
force-pushed
the
allow-targets-in-generator
branch
2 times, most recently
from
2d9e92f to
b02868e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #9290