Skip to content

fix(sip): fix one-way audio after long hold #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lminiero merged 1 commit into from
Apr 29, 2026
Merged

fix(sip): fix one-way audio after long hold #3640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/plugins/janus_sip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7179,6 +7179,10 @@ void janus_sip_save_reason(sip_t const *sip, janus_sip_session *session) {
void janus_sip_sdp_process(janus_sip_session *session, janus_sdp *sdp, gboolean answer, gboolean update, gboolean *changed) {
if(!session || !sdp)
return;
/* Remember the previous media reception state, so we can detect a hold->resume
* transition and reset the RTP switching context accordingly */
gboolean old_audio_recv = session->media.audio_recv;
gboolean old_video_recv = session->media.video_recv;
/* c= */
int opusred_pt = answer ? janus_sdp_get_opusred_pt(sdp, -1) : -1;
if(sdp->c_addr) {
Expand Down Expand Up @@ -7351,6 +7355,16 @@ void janus_sip_sdp_process(janus_sip_session *session, janus_sdp *sdp, gboolean
} while(res == -1 && errno == EINTR);
}
}
/* If media reception transitioned from disabled (e.g. hold) to enabled
* (e.g. unhold), reset the RTP switching context so the next outbound
* sequence number is monotonic relative to the last one we sent. Without
* this, after a long hold the peer's RTP seq may have wrapped uint16,
* producing an output seq that is lower than what srtp_protect already
* saw and causing it to fail with replay_old. */
if(!old_audio_recv && session->media.audio_recv)
session->media.acontext.seq_reset = TRUE;
if(!old_video_recv && session->media.video_recv)
session->media.vcontext.seq_reset = TRUE;
}

char *janus_sip_sdp_manipulate(janus_sip_session *session, janus_sdp *sdp, gboolean answer) {
Expand Down
Loading