Add shared dev environment integration#313
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a "Shared dev environment" bootstrap block to the Makefile that locates a sibling ChangesShared dev tooling setup
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 551-559: The tools bootstrap in the Makefile is happening during
parse time via the DEV_MK check and git clone call, so unrelated make goals can
trigger network access. Move the .tools/dev.mk download logic behind explicit
dev-related targets or a dedicated bootstrap target, and keep the existing
DEV_MK include path resolution in place so only those targets invoke the clone
when needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1d90f29e-2c05-439b-8417-3f2634dab25d
📒 Files selected for processing (2)
.gitignoreMakefile
657c49a to
db5722b
Compare
|
Depends-on: medik8s/tools#21 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Include the medik8s/tools dev environment snippet in the Makefile. Uses a local sibling checkout (../tools) if available, otherwise shallow-clones the tools repo into .tools/ on first use. Signed-off-by: Michal Pryc <mpryc@redhat.com>
db5722b to
3eb79c6
Compare
Why we need this PR
Integrates the shared medik8s dev environment from
medik8s/tools. Adding a small snippet to the Makefile gives all contributors access tomake dev-*targets for local development and testing.Changes made
../toolscheckout if available, otherwise shallow-clones the tools repo into.tools/on first use..tools/to ignore the auto-cloned copy.Available targets after this change
Also supports external clusters (OCP, etc.) with
SKIP_KIND=trueand ttl.sh ephemeral registry.Which issue(s) this PR fixes
N/A — new functionality.
Test plan
make dev-setup && make dev-deploy && make dev-describeworks on Kind (podman)SKIP_KIND=true make dev-setup && SKIP_KIND=true make dev-deployworks on OCPSummary by CodeRabbit
New Features
Chores