Add shared dev environment integration#410
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughAdds Makefile bootstrap logic for shared ChangesDev environment bootstrap
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 549-557: The Makefile bootstrap currently clones medik8s/tools
during parse time and hides failures, so restrict the clone logic to dev-*
target paths and keep it out of unrelated targets. Update the DEV_MK bootstrap
around the existing DEV_MK/TOOLS_DIR checks so the git clone only runs when a
dev target is being invoked, and if the clone or include still fails, emit a
clear error instead of silently relying on -include.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e626ec6f-0174-4c6f-9f7a-71dc2c18c1a4
📒 Files selected for processing (2)
.gitignoreMakefile
|
Depends-on: medik8s/tools#21 |
4153ef0 to
f7b138a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Makefile`:
- Around line 554-559: The bootstrap fallback in the dev-% rule is not
idempotent and can re-clone into an existing .tools directory, causing confusing
git failures; update the Makefile logic around DEV_MK and dev-% to clean or
reuse prior state before running git clone, then verify that dev/dev.mk is
present after cloning and fail with a clear error if it is still missing. Make
sure the recursive $(MAKE) $@ path does not loop back into the same fallback
when DEV_MK remains absent, and handle repeated dev-* targets consistently by
checking the existing tools checkout before cloning.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1ad4bd1e-2c26-40cc-af24-829a9c161651
📒 Files selected for processing (2)
.gitignoreMakefile
✅ Files skipped from review due to trivial changes (1)
- .gitignore
f7b138a to
5fb54b4
Compare
Include the medik8s/tools dev environment snippet in the Makefile. Uses a local sibling checkout (../tools) if available, otherwise shallow-clones the tools repo into .tools/ on first use. Signed-off-by: Michal Pryc <mpryc@redhat.com>
5fb54b4 to
3889f47
Compare
Why we need this PR
Integrates the shared medik8s dev environment from
medik8s/tools. Adding a small snippet to the Makefile gives all contributors access tomake dev-*targets for local development and testing.Changes made
../toolscheckout if available, otherwise shallow-clones the tools repo into.tools/on first use..tools/to ignore the auto-cloned copy.Available targets after this change
Also supports external clusters (OCP, etc.) with
SKIP_KIND=trueand ttl.sh ephemeral registry.Which issue(s) this PR fixes
N/A — new functionality.
Test plan
make dev-setup && make dev-deploy && make dev-describeworks on Kind (podman)SKIP_KIND=true make dev-setup && SKIP_KIND=true make dev-deployworks on OCPSummary by CodeRabbit
New Features
Chores
.tools/.