Skip to content

fix: #506 copy extend namespace will mounting files to temporary pack - #510

Open
edayot wants to merge 2 commits into
mcbeet:mainfrom
edayot:extend_namespace
Open

edayot wants to merge 2 commits into
mcbeet:mainfrom
edayot:extend_namespace

Conversation

@edayot

@edayot edayot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@edayot
edayot marked this pull request as ready for review March 29, 2026 13:12
@Stoupy51

Copy link
Copy Markdown

#506

@rx-dev

rx-dev commented Sep 1, 2026

Copy link
Copy Markdown
Member

Ah, I noticed this during summit with downloading sound object files I think

@rx-dev rx-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the issue referenced, I don't see how this PR will fix the bug

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the formatting of this file.. maybe just pipeline: [main] or

pipeline:
  - main

@edayot

edayot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Yeah i did not explain anything, sorry about that, the point is that if you want a custom NamespaceFileScope, fetching the object needs to create a temporary pack, but this temporary pack needs to have the same extend_namespace types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants