Skip to content

fix(ladder-shared): don't scroll to consist on pill click/sidebar open - #622

Merged
mathcolo merged 2 commits into
mainfrom
pim-rtui-3_0_0
Sep 9, 2026
Merged

fix(ladder-shared): don't scroll to consist on pill click/sidebar open#622
mathcolo merged 2 commits into
mainfrom
pim-rtui-3_0_0

Conversation

@mathcolo

@mathcolo mathcolo commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Asana Task: Last part of 🪜 Implement Orbit Redesign for Ladder Page

rail-tech-ui 3.0.0 separates highlight from scrollToConsist. Clicking a train on the Orbit ladder should be the former, not the latter.

⚠️ rail-tech-ui 3.0.0 is not yet out; hold for mbta/rail-tech-ui#20 and update this to a version pin.
Updated now.

Checklist

  • Appearance:
    • Light & dark mode
    • Desktop & mobile sizes
  • Browsers:
    • Chromium
    • Firefox
    • Safari
  • Privacy:
    • Commits free of internal data
    • PR description free of internal data
    • Logging free of internal data
  • Tests:
    • Has tests
    • Doesn't need tests this really amounts to configuration, but I could be convinced
    • Tests deferred (with justification)

@mathcolo
mathcolo requested a review from a team as a code owner September 4, 2026 20:25
Comment thread package.json Outdated
"esbuild": "0.28.2",
"luxon": "3.7.2",
"rail-tech-ui": "github:mbta/rail-tech-ui#v2.2.0",
"rail-tech-ui": "github:mbta/rail-tech-ui#aa8e47d93061ba414659eca5465d0e8a72150de5",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Is there a reason we haven't cut a tag for the new changes? Would that be better now that we have precedent of using a formal version number?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ rail-tech-ui 3.0.0 is not yet out; hold for mbta/rail-tech-ui#20 and update this to a version pin.

Ah, apologies, I missed this.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np!

@mathcolo
mathcolo merged commit d06edfc into main Sep 9, 2026
7 checks passed
@mathcolo
mathcolo deleted the pim-rtui-3_0_0 branch September 9, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants