Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 87.35% 87.38% +0.02%
==========================================
Files 90 90
Lines 8634 8653 +19
Branches 3060 3626 +566
==========================================
+ Hits 7542 7561 +19
Misses 1087 1087
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Sep 10, 2026
Closed
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The UI behavior changes are well-scoped, consistent with existing layout rules, and are covered by targeted unit and e2e tests.
Pull request overview
This PR updates Klinok to v0.15.3 and improves UI stability/formatting in medical history and laboratory comparison views, backed by updated unit and end-to-end tests.
Changes:
- Preserve line breaks for free-text medical history sections by introducing/using a shared
.medical-history-textstyling hook. - Make
AppCatalogComboboxkeep an open list stable across option refreshes (including two-level category edge cases). - Improve laboratory comparison table sizing/scroll behavior via a
colgroup, fixed column widths, and a computed CSS variable; extend e2e coverage for wide→narrow layouts.
File summaries
| File | Description |
|---|---|
| tests/medicalRecordEntry.spec.ts | Adds regression coverage for preserved line breaks; updates selector to .medical-history-text. |
| tests/laboratoryComparison.spec.ts | Asserts new colgroup structure and CSS-variable-driven width for the results table. |
| tests/appCatalogCombobox.spec.ts | Adds tests ensuring open list stability across option refresh and category disappearance. |
| src/styles.css | Introduces .medical-history-text pre-wrap styling and refines laboratory comparison table sizing/scroll behavior. |
| src/components/TherapeuticAppointmentView.vue | Switches therapeutic free-text blocks to .medical-history-text for pre-wrapped rendering. |
| src/components/MedicalRecordEntry.vue | Applies .medical-history-text to free-text section rendering in history/details. |
| src/components/LaboratoryComparison.vue | Adds CSS-variable-driven indicator width and a colgroup for predictable table layout. |
| src/components/AppCatalogCombobox.vue | Reworks watchers to reconcile active indices instead of closing on option refreshes. |
| packages/contracts/package.json | Bumps package version to 0.15.3. |
| package.json | Bumps root version to 0.15.3. |
| package-lock.json | Updates lockfile versions (incl. workspace versions) to 0.15.3 and refreshes some dependency resolutions. |
| e2e/operational.spec.ts | Expands e2e assertions for laboratory comparison indicator selection and responsive scrolling/column sizing. |
| api-node/package.json | Bumps API package version to 0.15.3. |
Review details
- Files reviewed: 12/13 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.