Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
========================================
Coverage 94.16% 94.16%
========================================
Files 76 76
Lines 6833 6833
Branches 2373 2908 +535
========================================
Hits 6434 6434
Misses 394 394
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The UI/layout change is scoped and is backed by both unit and E2E regression coverage, with no clear functional or maintainability issues found in the diff.
Pull request overview
This PR refines the pet-transfer manager UI on narrow screens by adding a “compact status + actions” row layout for pending transfers, and adjusts confirmation dialog wording to better reflect the non-destructive cancel action, with corresponding unit and E2E coverage.
Changes:
- Add a
transfer-row-has-actionsrow marker for pending transfers and apply a grid-based mobile layout to place status and action buttons on the same row. - Update the rejection confirmation dialog to use a clearer cancel label (“Сохранить запрос”) and strengthen unit coverage around dialog actions/labels.
- Extend E2E coverage to assert the new mobile alignment behavior and prevent horizontal overflow.
File summaries
| File | Description |
|---|---|
| tests/petTransfer.spec.ts | Adds assertions for the new pending-row class and verifies the rejection dialog cancel button label. |
| src/styles.css | Implements the mobile grid layout for pending transfer rows to align status and action buttons. |
| src/components/PetTransferManager.vue | Applies the pending-row class conditionally and sets the reject dialog cancel-label. |
| e2e/pet-transfer.spec.ts | Adds a mobile layout regression check ensuring status/actions align and no overflow occurs. |
| package.json | Bumps workspace version to 0.14.3. |
| api-node/package.json | Bumps package version to 0.14.3. |
| packages/contracts/package.json | Bumps package version to 0.14.3. |
| package-lock.json | Updates lockfile versions and dependency resolutions consistent with the version bump. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
No description provided.