Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds hysteresis to the display heater relay control by splitting the single relay threshold into distinct “on” and “off” thresholds, reducing relay chatter around the activation point while keeping prior behavior for read failures and shutdown safety.
Changes:
- Introduces separate relay on/off thresholds (with validation) and updates the control logic to apply hysteresis.
- Updates unit tests to validate hysteresis behavior and invalid-threshold rejection.
- Updates hardware documentation/config naming and bumps the project version.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/peripherals/temperature_sensor.cpp |
Implements hysteresis relay control, validates on/off thresholds, and logs configured thresholds during initialization. |
include/peripherals/temperature_sensor.h |
Updates constructor API to accept on/off thresholds and stores them as members with defaults for the callback-based constructor. |
include/hardware/hardware_config.h |
Replaces the single relay threshold constant with on/off threshold constants. |
tests/temperature_sensor_test.cpp |
Replaces the no-hysteresis relay test with a hysteresis behavior test and adds invalid-threshold coverage. |
docs/hardware.md |
Updates configuration docs and explains the new hysteresis behavior for the display heater relay. |
CMakeLists.txt |
Bumps the project version to 0.3.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.