fix: Build type resource path from method_name - #5
Merged
Conversation
`createPaymentType()` interpolated the `PaymentTypes` enum member itself, so the request went to `types/PaymentTypes.CARD` instead of `types/card`: > `"types/%s" % paymentType.method` -> `types/PaymentTypes.CARD` `method` holds the short code used in type ids (`crd`), while the types endpoint expects the full method name (`card`). Both are wrong when the enum member is stringified instead of its value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createPaymentType()interpolated thePaymentTypesenum member itself instead of a name,so every server-side type creation requested a non-existent path:
Two things were wrong at once: stringifying the enum member yields
PaymentTypes.CARDrather than a value, and
methodholds the short code used in type ids (crd) while thetypes endpoint expects the full method name (
card).Motivation
The bug stayed invisible as long as payment types were created on the client side (Payment
Page, UI components), which hands a ready
typeIdto the backend. It surfaces as soon as atype has to be created server-side — which is mandatory for Installment and Direct Bank
Transfer.
Verification
"types/%s" % Card.method_name.valueyieldstypes/card. For every payment type theresulting path was checked against the API reference (
api.unzer.com/swagger-ui/api-docs);all of them exist there. Not yet run against the sandbox API with a real keypair.