policyeval/commands: Fall back to continuwuityadmin when blocking rooms#52
Open
timedoutuk wants to merge 3 commits into
Open
policyeval/commands: Fall back to continuwuityadmin when blocking rooms#52timedoutuk wants to merge 3 commits into
timedoutuk wants to merge 3 commits into
Conversation
tulir
reviewed
Jul 3, 2026
| resp, err := ce.Meta.Bot.SynapseAdmin.DeleteRoomSync(ce.Ctx, roomID, req) | ||
| _, _ = ce.Meta.Bot.RedactEvent(ce.Ctx, ce.RoomID, reactionID) | ||
| if err != nil { | ||
| if errors.Is(err, mautrix.MUnrecognized) { |
Member
There was a problem hiding this comment.
This should be moved 2 lines up (between DeleteRoomSync and RedactEvent). errors.Is is fine with nil errors being passed so no need to gate the check. The response/error handling can also be shared (no need for a custom reply)
| } | ||
|
|
||
| func formatDeleteResult(resp synapseadmin.RespDeleteRoomResult) string { | ||
| func formatDeleteResult(kicked, failed []id.UserID, aliases []id.RoomAlias) string { |
Member
There was a problem hiding this comment.
These changes can be undone after mautrix/go#452 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mautrix/go#452
Falls back to continuwuity's admin API when using the synapse admin API fails (it should return M_UNRECOGNIZED for unknown routes). I also considered just specifying a
softwarein the config but that feels hacky.Ideally MSC4390: Room Blocking API will allow for this to be removed and unified in the future.