Fix Settings window intermittently not appearing - #188
Open
Arsey wants to merge 2 commits into
Open
Conversation
iMCP is an accessory app (LSUIElement = YES, no Dock icon). SwiftUI's openSettings() routes through a responder-chain action that only reliably lands when the app is already frontmost, which is ambiguous right as the custom menu bar popover dismisses — causing the window to randomly fail to open. Every other window-showing action in this file (About iMCP, connection approval) already works around this by calling NSApp.activate(ignoringOtherApps: true) first; Settings was the one path missing it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLDiNzrDds62dnD9NoCEJV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking "Settings..." in the menu sometimes does nothing — repeatedly. The failure is intermittent, which makes it look random, but it reproduces reliably on the first click after a fresh launch.
Root cause
iMCP is an accessory app (
LSUIElement), soopenSettings()alone is unreliable: it routes through a responder-chain action that only lands when the app is frontmost, which is ambiguous right as the menu popover dismisses. Both other window-showing paths in the same file (About, connection approval) already work around this by callingNSApp.activate(ignoringOtherApps: true)first — Settings was the one path missing it.Fix
Activate the app before calling
openSettings(), matching the existing pattern.Test plan
xcodebuild buildsucceeds