Skip to content

For easier command line using, I've added a new command with symfony/console - #106

Open
Clarence-pan wants to merge 7 commits into
matthiasmullie:masterfrom
Clarence-pan:master
Open

For easier command line using, I've added a new command with symfony/console#106
Clarence-pan wants to merge 7 commits into
matthiasmullie:masterfrom
Clarence-pan:master

Conversation

@Clarence-pan

Copy link
Copy Markdown

The original command line tools cannot directly specify an output file. It's painful in some cases.
So I added a new command with symfony/console. Then you can use it like this:

# for js files:
minify foo.js -o foo.min.js

# for css files:
minify foo.css -o foo.min.css

Hope you will like it and accept it.

p.s. In previous PL, PHP 5.4 complains... So I've change the symfony/console's version to >=2.0. It should be OK now.

@codecov-io

Copy link
Copy Markdown

Current coverage is 100.00%

Merging #106 into master will not affect coverage as of 43579cd

@@            master    #106   diff @@
======================================
  Files            3       3       
  Stmts          380     380       
  Branches         0       0       
  Methods         39      39       
======================================
  Hit            380     380       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 43579cd

Powered by Codecov. Updated on successful CI builds.

@matthiasmullie

Copy link
Copy Markdown
Owner

Hey @Clarence-pan, thanks a lot for this PR!

Any chance you could also include some tests for the MinifyCommand class?
Bonus points if you could also update bin/minifycss & bin/minifyjs to also use the same code :)

@matthiasmullie
matthiasmullie force-pushed the master branch 2 times, most recently from 85ee174 to 227f190 Compare December 27, 2020 21:43
@matthiasmullie
matthiasmullie force-pushed the master branch 3 times, most recently from 949e01d to 51d1aa4 Compare November 18, 2022 12:22
@matthiasmullie
matthiasmullie force-pushed the master branch 2 times, most recently from 9ddadb8 to 4c4ecee Compare March 6, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants