Skip to content

rev C: honor a STARTMODE config option for power-on display - #1076

Open
jeffreyjacques wants to merge 1 commit into
mathoudebine:mainfrom
jeffreyjacques:feat/rev-c-startmode
Open

rev C: honor a STARTMODE config option for power-on display#1076
jeffreyjacques wants to merge 1 commit into
mathoudebine:mainfrom
jeffreyjacques:feat/rev-c-startmode

Conversation

@jeffreyjacques

Copy link
Copy Markdown

The revision C protocol already defines STARTMODE_DEFAULT/IMAGE/VIDEO (byte 0 of the OPTIONS payload), but SetOrientation always sent DEFAULT, which blanks the panel at power-on until the host connects. The panel keeps this setting across power cycles.

Read an optional display.STARTMODE config value (DEFAULT/IMAGE/VIDEO) so a display fitted with an SD card can instead replay the last image or video it was sent. Defaults to DEFAULT, so behavior is unchanged unless the option is set; unknown values warn and fall back to DEFAULT.

config.yaml is intentionally not modified (guarded by CI); maintainers can add the documented 'STARTMODE: DEFAULT' key to the shipped template.

@mathoudebine

Copy link
Copy Markdown
Owner

Thank you for the PR!
FYI your commits are not properly associated with your Github account:

image

if this is not intentional you may need to configure your Git environment following this documentation: https://docs.github.com/en/account-and-profile/how-tos/email-preferences/setting-your-commit-email-address
Let me know if you want to update this before I merge your PR (and the other one)

The revision C protocol already defines STARTMODE_DEFAULT/IMAGE/VIDEO
(byte 0 of the OPTIONS payload), but SetOrientation always sent DEFAULT,
which blanks the panel at power-on until the host connects. The panel
keeps this setting across power cycles.

Read an optional display.STARTMODE config value (DEFAULT/IMAGE/VIDEO) so
a display fitted with an SD card can instead replay the last image or
video it was sent. Defaults to DEFAULT, so behavior is unchanged unless
the option is set; unknown values warn and fall back to DEFAULT.

config.yaml is intentionally not modified (guarded by CI); maintainers
can add the documented 'STARTMODE: DEFAULT' key to the shipped template.
@jeffreyjacques

Copy link
Copy Markdown
Author

Fixed the association. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants