Repository navigation
chore(lint): ban every private marimo package outside compat - #103
Merged
Merged
Conversation
The Ruff banned-api list missed marimo._convert and marimo._output, which compat already imports. List every private Python module shipped by the pinned marimo 0.25.1 so the fast lint matches the boundary test.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
marimo-export uv pip install "marimo-export @ https://github.com/marimo-team/marimo-export/releases/download/preview/marimo_export-0.2.2.dev2-py3-none-any.whl"
pnpm add "https://github.com/marimo-team/marimo-export/releases/download/preview/marimo-team-marimo-export-0.2.2-dev.2.tgz" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff's banned-api list covered only some private marimo packages, so imports of
marimo._convertandmarimo._outputoutsidemarimo_export._marimo.compatpassed the fast lint. This lists every private Python module that the pinned marimo 0.25.1 ships. The lint now catches a misplaced private import before the boundary test runs.