Skip to content

fix: restore cookies from storage state before login check - #3

Merged
malyjacob merged 1 commit into
mainfrom
fix/restore-storage-state-cookies
Aug 14, 2026
Merged

malyjacob merged 1 commit into
mainfrom
fix/restore-storage-state-cookies

Conversation

@malyjacob

@malyjacob malyjacob commented Aug 14, 2026 •

Copy link
Copy Markdown
Owner

Summary by Sourcery

Bug Fixes:

  • Load cookies from existing storage-state file into the browser context before applying configured cookies to ensure prior sessions are correctly restored.

@sourcery-ai

sourcery-ai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Restores cookies from a persisted Playwright storage state before applying configured cookies and navigating, improving session restoration and login checks.

Sequence diagram for restoring storage-state cookies before navigation

sequenceDiagram
    participant BrowserManager
    participant fs
    participant BrowserContext as context
    participant logger
    participant Page as page

    BrowserManager->>BrowserManager: applyStorageStateCookies()
    alt [context exists]
        BrowserManager->>fs: existsSync(STORAGE_STATE_FILE)
        alt [storage state file exists]
            BrowserManager->>fs: readFileSync(STORAGE_STATE_FILE)
            BrowserManager->>BrowserManager: JSON.parse(state).cookies
            BrowserManager->>context: addCookies(cookies)
            context-->>BrowserManager: cookies applied
            BrowserManager->>logger: fileLog()
        end
    end

    BrowserManager->>BrowserManager: applyConfigCookies()
    BrowserManager->>page: goto(https://zujuan.xkw.com)
    page-->>BrowserManager: domcontentloaded
Loading

File-Level Changes

Change Details Files
Restore cookies from storage state before applying configured cookies when initializing the browser context
  • Invoke a new storage-state cookie restoration method before applying configuration cookies and navigating to the initial page
  • Guard against missing browser context or storage-state file before attempting restoration
  • Parse the storage state JSON file and extract cookie entries
  • Filter cookies to only those with required name and domain fields before adding them to the context
  • Add cookies to the Playwright browser context and log the number of restored cookies
  • Catch and log any errors during storage-state cookie restoration at WARN level
src/lib/browser.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider avoiding synchronous fs.readFileSync inside the async applyStorageStateCookies method and switch to the async fs.promises.readFile to prevent blocking the event loop.
  • The inline cookie shape in applyStorageStateCookies is duplicated logic; extracting a shared Cookie type/interface or reusing existing Playwright types would simplify maintenance and reduce mismatch risk.
  • The catch block in applyStorageStateCookies logs only error string interpolation; you may want to log error instanceof Error ? error.stack : error to capture more useful debugging information.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding synchronous `fs.readFileSync` inside the async `applyStorageStateCookies` method and switch to the async `fs.promises.readFile` to prevent blocking the event loop.
- The inline cookie shape in `applyStorageStateCookies` is duplicated logic; extracting a shared Cookie type/interface or reusing existing Playwright types would simplify maintenance and reduce mismatch risk.
- The catch block in `applyStorageStateCookies` logs only `error` string interpolation; you may want to log `error instanceof Error ? error.stack : error` to capture more useful debugging information.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@malyjacob
malyjacob merged commit b7a2757 into main Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant