Repository navigation
fix: restore cookies from storage state before login check - #3
Merged
Merged
Conversation
Reviewer's GuideRestores cookies from a persisted Playwright storage state before applying configured cookies and navigating, improving session restoration and login checks. Sequence diagram for restoring storage-state cookies before navigationsequenceDiagram
participant BrowserManager
participant fs
participant BrowserContext as context
participant logger
participant Page as page
BrowserManager->>BrowserManager: applyStorageStateCookies()
alt [context exists]
BrowserManager->>fs: existsSync(STORAGE_STATE_FILE)
alt [storage state file exists]
BrowserManager->>fs: readFileSync(STORAGE_STATE_FILE)
BrowserManager->>BrowserManager: JSON.parse(state).cookies
BrowserManager->>context: addCookies(cookies)
context-->>BrowserManager: cookies applied
BrowserManager->>logger: fileLog()
end
end
BrowserManager->>BrowserManager: applyConfigCookies()
BrowserManager->>page: goto(https://zujuan.xkw.com)
page-->>BrowserManager: domcontentloaded
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider avoiding synchronous
fs.readFileSyncinside the asyncapplyStorageStateCookiesmethod and switch to the asyncfs.promises.readFileto prevent blocking the event loop. - The inline cookie shape in
applyStorageStateCookiesis duplicated logic; extracting a shared Cookie type/interface or reusing existing Playwright types would simplify maintenance and reduce mismatch risk. - The catch block in
applyStorageStateCookieslogs onlyerrorstring interpolation; you may want to logerror instanceof Error ? error.stack : errorto capture more useful debugging information.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider avoiding synchronous `fs.readFileSync` inside the async `applyStorageStateCookies` method and switch to the async `fs.promises.readFile` to prevent blocking the event loop.
- The inline cookie shape in `applyStorageStateCookies` is duplicated logic; extracting a shared Cookie type/interface or reusing existing Playwright types would simplify maintenance and reduce mismatch risk.
- The catch block in `applyStorageStateCookies` logs only `error` string interpolation; you may want to log `error instanceof Error ? error.stack : error` to capture more useful debugging information.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: