Skip to content

Add pre-commit, poetry and use type hinting - #78

Open
BenWolfaardt wants to merge 10 commits into
mallorbc:mainfrom
BenWolfaardt:main
Open

Add pre-commit, poetry and use type hinting#78
BenWolfaardt wants to merge 10 commits into
mallorbc:mainfrom
BenWolfaardt:main

Conversation

@BenWolfaardt

Copy link
Copy Markdown

Hey, thanks for the awesome project.

I was considering adding support to allow a keyboard shortcut to toggle the start and end of a transcription session as I find that the --loop flag often results in poor transcriptions as sentences are randomly split and the model looses a lot of context.

I created a PoC for this, but first wanted to tidy things up before making any major changes. I'm not sure you'll agree with the addition of poetry or all of y ruff rules, but it enforces homogeneity across the code as well as makes things easier to work with.

Please let me know your thoughts and suggestions.

Kind regards,
Ben

@mallorbc

Copy link
Copy Markdown
Owner

Thanks for the PR. I will be dedicating time for this project this upcoming week to handle this and many other issues.

@mallorbc

mallorbc commented Jul 4, 2024

Copy link
Copy Markdown
Owner

Finally doing a lot of work on this repo today. Not sure why you deleted init.py but the rest looks good. I am gonna test it out and see if its good.

@mallorbc

mallorbc commented Jul 4, 2024

Copy link
Copy Markdown
Owner

With regard to your comments, I think a keyboard shortcut or something of the like would be great. Yeah, the current implementation sometimes loses some words and punctuation context.

@mallorbc

mallorbc commented Jul 4, 2024

Copy link
Copy Markdown
Owner

I am not able to install this using poetry install. I am getting a message like:
Installing dependencies from lock file

Package operations: 14 installs, 0 updates, 0 removals

  • Installing triton (2.3.1): Failed

RuntimeError

Unable to find installation candidates for triton (2.3.1)

at /opt/homebrew/Cellar/poetry/1.8.3_2/libexec/lib/python3.12/site-packages/poetry/installation/chooser.py:74 in choose_for
70│
71│ links.append(link)
72│
73│ if not links:
→ 74│ raise RuntimeError(f"Unable to find installation candidates for {package}")
75│
76│ # Get the best link
77│ chosen = max(links, key=lambda link: self._sort_key(package, link))
78│

Cannot install triton.

@mallorbc

mallorbc commented Jul 4, 2024

Copy link
Copy Markdown
Owner

Also, is it possible to install in editable form?

Like pip install -e .

@mallorbc

mallorbc commented Jul 4, 2024

Copy link
Copy Markdown
Owner

I really like the other changes though. Let me know if you want to proceed. Otherwise I might add them in other ways.

@PortMaster1

Copy link
Copy Markdown

I also like the ideas of this PR and hope they come back to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants