Skip to content

feat(runtime): converge language guards - #764

Open
majiayu000 wants to merge 20 commits into
mainfrom
fix/gh752-guard-convergence
Open

feat(runtime): converge language guards#764
majiayu000 wants to merge 20 commits into
mainfrom
fix/gh752-guard-convergence

Conversation

@majiayu000

Copy link
Copy Markdown
Owner

Summary

  • move all 15 Rust, Go, and TypeScript language guard implementations into vibeguard-runtime scan
  • retain fail-closed shell compatibility shims and remove duplicate shell scanner logic
  • add staged/baseline correctness coverage plus exact shim/runtime behavior parity for every migrated rule
  • bump the runtime release version to 1.1.17

Validation

  • cargo fmt --manifest-path vibeguard-runtime/Cargo.toml -- --check
  • cargo check --manifest-path vibeguard-runtime/Cargo.toml
  • cargo test --manifest-path vibeguard-runtime/Cargo.toml
  • bash tests/unit/run_all.sh (24/24)
  • bash tests/test_behavior_eval.sh (16/16)
  • bash tests/test_payload.sh (45/45)
  • guard, hook, manifest, documentation validators
  • bash scripts/local-contract-check.sh --quick
  • git diff --check

Closes #752

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25adcea527

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fcddeb9aef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/go.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread guards/rust/runtime-shim.sh Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 160002279a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hook Latency (P95)

Details
Benchmark suite Current: dda3d2d Previous: d4938a8 Ratio
e2e pre-edit P50 74 ms 93 ms 0.80
e2e pre-edit P95 75 ms 93 ms 0.81
e2e pre-edit P99 75 ms 93 ms 0.81
e2e pre-write P50 73 ms 91 ms 0.80
e2e pre-write P95 73 ms 91 ms 0.80
e2e pre-write P99 73 ms 91 ms 0.80
e2e pre-bash P50 78 ms 97 ms 0.80
e2e pre-bash P95 78 ms 98 ms 0.80
e2e pre-bash P99 78 ms 98 ms 0.80
e2e post-edit 100 P50 74 ms 95 ms 0.78
e2e post-edit 100 P95 75 ms 95 ms 0.79
e2e post-edit 100 P99 75 ms 95 ms 0.79
e2e post-write 100 P50 77 ms 96 ms 0.80
e2e post-write 100 P95 78 ms 96 ms 0.81
e2e post-write 100 P99 78 ms 96 ms 0.81
e2e post-build fake P50 65 ms 76 ms 0.86
e2e post-build fake P95 66 ms 76 ms 0.87
e2e post-build fake P99 66 ms 76 ms 0.87
e2e codex pre-bash P50 29 ms 34 ms 0.85
e2e codex pre-bash P95 30 ms 34 ms 0.88
e2e codex pre-bash P99 30 ms 34 ms 0.88
e2e codex post-edit 100 P50 29 ms 34 ms 0.85
e2e codex post-edit 100 P95 29 ms 34 ms 0.85
e2e codex post-edit 100 P99 29 ms 34 ms 0.85
e2e post-edit 5000 P50 76 ms 95 ms 0.80
e2e post-edit 5000 P95 76 ms 96 ms 0.79
e2e post-edit 5000 P99 76 ms 96 ms 0.79
e2e post-write 5000 P50 77 ms 96 ms 0.80
e2e post-write 5000 P95 77 ms 97 ms 0.79
e2e post-write 5000 P99 77 ms 97 ms 0.79
e2e stop 5000 P50 12 ms 14 ms 0.86
e2e stop 5000 P95 12 ms 15 ms 0.80
e2e stop 5000 P99 12 ms 15 ms 0.80
e2e learn 5000 P50 12 ms 14 ms 0.86
e2e learn 5000 P95 12 ms 14 ms 0.86
e2e learn 5000 P99 12 ms 14 ms 0.86

This comment was automatically generated by workflow using github-action-benchmark.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 020db1a0c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread eval/run_behavior_eval.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e68ebb0a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80d695d553

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d1bd2ce6c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/shared.rs
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea05de4a96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d3f3cc87e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread eval/behavior/requirements.json
Comment thread CONTRIBUTING.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5026a61911

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread eval/run_behavior_eval.py Outdated
Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f235248c56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f30182f25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/hook_checks/js.rs
Comment thread guards/go/runtime-shim.sh Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de0a08b412

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b3d2d8f53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/shared.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 315f20bc86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread guards/go/runtime-shim.sh

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c1c6e90cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/jsx.rs
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/rust.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/shared.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cb9d1a2b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/jsx.rs Outdated
Comment thread eval/run_behavior_eval.py
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs Outdated
Comment thread vibeguard-runtime/src/guard_scan/go.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dda3d2d875

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vibeguard-runtime/src/guard_scan/shared.rs
Comment thread vibeguard-runtime/src/guard_scan/typescript.rs
Comment thread vibeguard-runtime/src/guard_scan/rust_structural.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guard convergence: migrate guards/<lang> shell rules into the Rust runtime (Phase 3, F1)

1 participant