Test new outlet#4
Open
BobrImperator wants to merge 13 commits into
Open
Conversation
| /** | ||
| * Appends `into` without clearing the target first. Mimics the `appendTo` behavior for classic components. | ||
| */ | ||
| appendIntoTarget?: boolean; |
There was a problem hiding this comment.
this will need a bunch more tests <3
in particular:
renderCompnoent(A, { appendTo: IntoTarget })
renderComponent(B, { appendTo: IntoTarget })
and do the reactivity of A and B stay in the same location and not re-order themselves?
(This was the issue I ran in to during implementation, in that whatever was updated last would become last in DOM-order)
(also, I think this behavior will need its own RFC, describing the stability of render-order (and update-order), and probably appendTo rather than a booling, imo -- boolean configurable options are a bit of an ick for me)
BobrImperator
force-pushed
the
test-new-outlet
branch
from
July 16, 2026 08:37
4adfd8d to
089323c
Compare
📊 Size reportTarball size — dist/dev -0.17%↓
dist/prod -0.15%↓
smoke-tests/v2-app-template/dist 0.2%↑
smoke-tests/v2-app-hello-world-template/dist 0.06%↑
🤖 This report was automatically generated by wyvox/pkg-size |
move outlet close to the route manager impl
Apply onto for classic components
this should also autoresolve once currying is removed
BobrImperator
force-pushed
the
test-new-outlet
branch
from
July 16, 2026 08:46
089323c to
6382317
Compare
BobrImperator
commented
Jul 16, 2026
| @@ -3,14 +3,14 @@ import type { Nullable } from '@ember/-internals/utility-types'; | |||
| import { assert } from '@ember/debug'; | |||
| import type EngineInstance from '@ember/engine/instance'; | |||
Author
There was a problem hiding this comment.
move to the route-managers/classic/ directory - this is where its only consumers are
BobrImperator
commented
Jul 16, 2026
| @@ -1,5 +1,5 @@ | |||
| import { precompileTemplate } from '@ember/template-compilation'; | |||
| import { outletHelper } from '../syntax/outlet'; | |||
mansona
reviewed
Jul 16, 2026
| let inExpected = key in (expected as object); | ||
| let inActual = key in (actual as object); | ||
|
|
||
| if (key !== 'outlet') { |
Member
There was a problem hiding this comment.
we should probably remove this "ignore" of the outlet key 🤔 i don't know how we're going to be able to test it properly but at least it won't crash the browser while you're working on this
BobrImperator
force-pushed
the
test-new-outlet
branch
from
July 16, 2026 12:55
835960b to
523d52e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.