Fix ConsoleRender.height returning terminal.width - #726
Open
cristianchiriac wants to merge 1 commit into
Open
cristianchiriac wants to merge 1 commit into
cristianchiriac wants to merge 1 commit into
Conversation
…ight The height property returned self.terminal.width, so height and width were always identical. This breaks anything that positions output relative to the bottom of the terminal using self.terminal.location(), such as render_in_bottombar(), which can end up writing to a row outside the terminal and never showing the message. Fixes magmax#164
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
Bug
ConsoleRender.heightreturnsself.terminal.widthinstead ofself.terminal.height:So
widthandheightare always identical, which breaks anything that positions output relative to the bottom of the terminal usingself.terminal.location(), e.g.render_in_bottombar()— the y-coordinate is computed fromself.height, so on a terminal where width and height differ, it writes outside the visible area and the message never shows up.Fix
One-line fix: read
self.terminal.heightinstead ofself.terminal.width.Test plan
test_height_uses_terminal_height_not_width, which stubsterminalwith distinctwidth/heightvalues and asserts each property reads the matching attribute.heightreturning thewidthvalue) and passes with the fix.pytest tests/ --ignore=tests/acceptance(the acceptance tests needpexpect, which isn't available in this environment): 139 passed, 1 skipped.flake8on the changed files: clean.