Harden the scheduled workflows - #90
Merged
Merged
Conversation
- Pin cargo-expand: its output shape feeds the snapshots, so an unpinned upgrade reads as codegen drift and misattributes the cause. - Add concurrency groups: the bot branch is force-pushed, and the tracking issue is decided per run, so overlapping runs would fight each other. - Stage before diffing, so a snapshot for a newly added test is not missed while it is still untracked. - Drop the checkout credentials in latest-deps, which never pushes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pin only covered half the pipeline: PR CI compares the expansion
snapshots that the nightly workflow regenerates, but installed its own
unpinned cargo-expand, so the two could expand with different versions.
Also drops the archived actions-rs/{toolchain,cargo} actions in favour of
rustup and plain cargo, as the composite action already did.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
madonoharu
force-pushed
the
phase06/ci-hardening
branch
from
August 17, 2026 01:12
7f48beb to
0c24dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups on the scheduled workflows from #87, found while reviewing them against what they actually guarantee.
git diff --quiet -- testsmisses the snapshot for a newly added test, which stays untracked until staged.Also unifies PR CI with the same setup action: the pin only covered half the pipeline, since PR CI compares the very snapshots the nightly workflow regenerates but installed its own unpinned cargo-expand. That removes the last uses of the archived
actions-rs/*actions too.Still open (bigger, kept separate): the expand workflow holds
contents/pull-requests/issues: writefor the whole job, including dependency resolution and the build. Splitting it into a read-only expand job that uploads the diff as an artifact and a write-scoped job that pushes would confine the token.🤖 Generated with Claude Code